From dfa2b0e1c95bf72d58bbff9fb5c4045521af04d6 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Wed, 18 Nov 2020 16:30:32 +1100 Subject: [PATCH] Fix T82800: Changing settings from a pie menu doesn't add undo steps Pie menu had inconsistent behavior for dragging & releasing the key compared to clicking on the button. This was caused by the `onfree` argument being set to true, preventing the button from running callbacks such as setting up undo data & auto-keyframe This argument should only be used when freeing the button, set this to false as is done for regular menus. --- source/blender/editors/interface/interface_handlers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c index 7e9461e7751..5be335f0e6e 100644 --- a/source/blender/editors/interface/interface_handlers.c +++ b/source/blender/editors/interface/interface_handlers.c @@ -10211,8 +10211,7 @@ static int ui_but_pie_menu_apply(bContext *C, menu->menuretval = UI_RETURN_CANCEL; } else { - ui_apply_but(C, but->block, but, but->active, false); - button_activate_exit((bContext *)C, but, but->active, false, true); + button_activate_exit((bContext *)C, but, but->active, false, false); menu->menuretval = UI_RETURN_OK; }