archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Bugfix #8255: Negative Rotation Values with Transform Constraint go Crazy

Browse Source 
This bug-report brought to light some problems with the transform constraint's handling of degrees+radians. Now, the input-range scaling is done in degrees (as the clamping factors ranges are in degrees) instead of having that done after this stage. The problems should now be fixed (and gears now seem to work ok), but I hope no other rigs have been broken.
This commit is contained in:
Joshua Leung
2008-02-15 04:42:48 +00:00
parent cd3d63a628
commit edd2ba38bd
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/blenkernel/intern/constraint.c
View File

@@ -3062,8 +3062,10 @@ static void transform_evaluate (bConstraint *con, bConstraintOb *cob, ListBase *
case 2: /* scale */
Mat4ToSize(ct->matrix, dvec);
break;
case 1: /* rotation */
case 1: /* rotation (convert to degrees first) */
Mat4ToEul(ct->matrix, dvec);
for (i=0; i<3; i++)
dvec[i] = dvec[i] / M_PI * 180;
break;
default: /* location */
VecCopyf(dvec, ct->matrix[3]);
@@ -3095,14 +3097,9 @@ static void transform_evaluate (bConstraint *con, bConstraintOb *cob, ListBase *
}
}
/* convert radian<->degree */
if (data->from==1 && data->to==0) {
/* from radians to degrees */
for (i=0; i<3; i++)
sval[i] = sval[i] / M_PI * 180;
}
else if (data->from==0 && data->to==1) {
/* from degrees to radians */
/* convert radians<->degrees */
if (data->to == 1) {
/* if output is rotation, convert to radians from degrees */
for (i=0; i<3; i++)
sval[i] = sval[i] / 180 * M_PI;
}