Cleanup: use const variables where possible in the Python API
This commit is contained in:
@@ -78,7 +78,7 @@ static int bpygpu_uniform_location_get(GPUShader *shader,
|
||||
const char *name,
|
||||
const char *error_prefix)
|
||||
{
|
||||
int uniform = GPU_shader_get_uniform(shader, name);
|
||||
const int uniform = GPU_shader_get_uniform(shader, name);
|
||||
|
||||
if (uniform == -1) {
|
||||
PyErr_Format(PyExc_ValueError, "%s: uniform %.32s not found", error_prefix, name);
|
||||
@@ -158,7 +158,7 @@ static PyObject *bpygpu_shader_uniform_from_name(BPyGPUShader *self, PyObject *a
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int uniform = bpygpu_uniform_location_get(self->shader, name, "GPUShader.get_uniform");
|
||||
const int uniform = bpygpu_uniform_location_get(self->shader, name, "GPUShader.get_uniform");
|
||||
|
||||
if (uniform == -1) {
|
||||
return NULL;
|
||||
@@ -184,7 +184,7 @@ static PyObject *bpygpu_shader_uniform_block_from_name(BPyGPUShader *self, PyObj
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int uniform = GPU_shader_get_uniform_block(self->shader, name);
|
||||
const int uniform = GPU_shader_get_uniform_block(self->shader, name);
|
||||
|
||||
if (uniform == -1) {
|
||||
PyErr_Format(PyExc_ValueError, "GPUShader.get_uniform_block: uniform %.32s not found", name);
|
||||
@@ -504,7 +504,7 @@ static PyObject *bpygpu_shader_attr_from_name(BPyGPUShader *self, PyObject *arg)
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int attr = GPU_shader_get_attribute(self->shader, name);
|
||||
const int attr = GPU_shader_get_attribute(self->shader, name);
|
||||
|
||||
if (attr == -1) {
|
||||
PyErr_Format(PyExc_ValueError, "GPUShader.attr_from_name: attribute %.32s not found", name);
|
||||
|
||||
@@ -134,7 +134,7 @@ static bool bpygpu_vertbuf_fill_impl(GPUVertBuf *vbo,
|
||||
return false;
|
||||
}
|
||||
|
||||
uint comp_len = pybuffer.ndim == 1 ? 1 : (uint)pybuffer.shape[1];
|
||||
const uint comp_len = pybuffer.ndim == 1 ? 1 : (uint)pybuffer.shape[1];
|
||||
|
||||
if (pybuffer.shape[0] != vbo->vertex_len) {
|
||||
PyErr_Format(
|
||||
|
||||
@@ -112,7 +112,7 @@ static int bpygpu_ParseVertCompType(PyObject *o, void *p)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int comp_type = bpygpu_parse_component_type(str, length);
|
||||
const int comp_type = bpygpu_parse_component_type(str, length);
|
||||
if (comp_type == -1) {
|
||||
PyErr_Format(PyExc_ValueError, "unknown component type: '%s", str);
|
||||
return 0;
|
||||
@@ -132,7 +132,7 @@ static int bpygpu_ParseVertFetchMode(PyObject *o, void *p)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int fetch_mode = bpygpu_parse_fetch_mode(str, length);
|
||||
const int fetch_mode = bpygpu_parse_fetch_mode(str, length);
|
||||
if (fetch_mode == -1) {
|
||||
PyErr_Format(PyExc_ValueError, "unknown type literal: '%s'", str);
|
||||
return 0;
|
||||
|
||||
Reference in New Issue
Block a user