Julian Eisel
a958ae36e8
Various UI code would store the `AssetHandle` in a way that turns out to be unsafe. The file-data is part of the file browser caching system that releases file-data when a certain maximum of items is in the cache. So even while just iterating over the assets, earlier iterated asset handles may become invalid. Now asset handles are really treated as volatile, short lived objects. For the asset-view, the fix was more involved. There we need an RNA collection of asset-handles, because the UI list code requires that. So we create a dummy collection and get the asset handles as needed by index. This again meant that I had to keep the index of the collection and the asset-list in sync, so all filtering had to be moved to the UI list. I tried duplicating the file-data out of the cache instead, but that caused problems with managing the memory/ownership of the preview images. `AssetHandle` should be removed and replaced by `AssetRepresentation`, but this would be an even more disruptive change (breaking API compatibility too). Fixes #104305, #105535. Pull Request: #105773
50 lines
1.6 KiB
C++
50 lines
1.6 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup edasset
|
|
*
|
|
* Asset-handle is a temporary design, not part of the core asset system design.
|
|
*
|
|
* Currently asset-list items are just file directory items (#FileDirEntry). So an asset-handle
|
|
* just wraps a pointer to this. We try to abstract away the fact that it's just a file entry,
|
|
* although that doesn't always work (see #rna_def_asset_handle()).
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "DNA_ID_enums.h"
|
|
#include "DNA_asset_types.h"
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
struct AssetHandle;
|
|
|
|
struct AssetRepresentation *ED_asset_handle_get_representation(const struct AssetHandle *asset);
|
|
const char *ED_asset_handle_get_name(const struct AssetHandle *asset);
|
|
struct AssetMetaData *ED_asset_handle_get_metadata(const struct AssetHandle *asset);
|
|
struct ID *ED_asset_handle_get_local_id(const struct AssetHandle *asset);
|
|
ID_Type ED_asset_handle_get_id_type(const struct AssetHandle *asset);
|
|
int ED_asset_handle_get_preview_icon_id(const struct AssetHandle *asset);
|
|
void ED_asset_handle_get_full_library_path(
|
|
const struct AssetHandle *asset,
|
|
/* `1090` for #FILE_MAX_LIBEXTRA,
|
|
* rely on warnings to let us know if this gets out of sync. */
|
|
char r_full_lib_path[1090]);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#ifdef __cplusplus
|
|
|
|
# include <optional>
|
|
|
|
/** The asset library may have an import method (e.g. append vs. link) defined to use. If so, this
|
|
* returns it. Otherwise a reasonable method should be used, usually "Append (Reuse Data)". */
|
|
std::optional<eAssetImportMethod> ED_asset_handle_get_import_method(
|
|
const struct AssetHandle *asset);
|
|
|
|
#endif
|