From 014fba28315dd07b903a45b54690a9734da4dd36 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Fri, 12 Jul 2013 12:07:52 -0700 Subject: [PATCH] Pholio - finish off making public (ie not logged in) views work Summary: Fixes T2652. Did some testing post T2691 to see if I could close this and noted an error in the JS if you view the page not logged in. This fixes that error. Everything else I can think of seems to work...? :D Test Plan: played around with a mock not logged in and got sensible interactions and no errors Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2652 Differential Revision: https://secure.phabricator.com/D6438 --- .../rsrc/js/application/pholio/behavior-pholio-mock-view.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js b/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js index 1b0b6c0f74..06b6530a5e 100644 --- a/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js +++ b/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js @@ -631,7 +631,9 @@ JX.behavior('pholio-mock-view', function(config) { } load_inline_comments(); - JX.DOM.invoke(JX.$(config.commentFormID), 'shouldRefresh'); + if (config.loggedIn) { + JX.DOM.invoke(JX.$(config.commentFormID), 'shouldRefresh'); + } JX.Stratcom.listen('resize', null, redraw_image); redraw_image();