From 08aefafef75a5c6a6d2d6620cc82d556f23e5f94 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 23 Mar 2015 09:10:10 -0700
Subject: [PATCH] Remove redundant administrator requirement from application
 edit policy page

Summary:
Fixes T7485. Before applications had proper policies, we gated access by requiring the viewer be an administrator.

This is now redundant (CAN_EDIT on applications has the same effect, and performs the same check), and may some day be wrong (we might let administrators configure a different policy to control who can configure applications). Today, it gets the policy dialog wrong.

Test Plan:
Clicked "Edit Policies" as a non-administrator, was unable to, got nice error:

{F346598}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7485

Differential Revision: https://secure.phabricator.com/D12125
---
 .../meta/controller/PhabricatorApplicationEditController.php  | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/applications/meta/controller/PhabricatorApplicationEditController.php b/src/applications/meta/controller/PhabricatorApplicationEditController.php
index b29d33b7ce..dffb46c6a1 100644
--- a/src/applications/meta/controller/PhabricatorApplicationEditController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationEditController.php
@@ -3,10 +3,6 @@
 final class PhabricatorApplicationEditController
   extends PhabricatorApplicationsController {
 
-  public function shouldRequireAdmin() {
-    return true;
-  }
-
   public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
     $application = $request->getURIData('application');