From 091248ebe637e5a8d43dfbd9dc8eba5fd61e7b8d Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Tue, 17 Apr 2012 16:35:45 -0700
Subject: [PATCH] Link to "large" view from inline comment for previous
 revision

Summary: Also link to `D1?id=` instead of `?id=` because some IE versions linked to root in this case.

Test Plan: Click on old diff's inline comment link on large revision.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2260
---
 .../revisioncomment/DifferentialRevisionCommentView.php     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
index d74e2e719b..aa002b5736 100644
--- a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
+++ b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
@@ -291,7 +291,11 @@ final class DifferentialRevisionCommentView extends AphrontView {
         if (!$is_visible) {
           $diff_id = $changeset->getDiffID();
           $item['where'] = '(On Diff #'.$diff_id.')';
-          $item['href']  = '?id='.$diff_id.'#inline-'.$inline->getID();
+          $item['href'] =
+            'D'.$this->comment->getRevisionID().
+            '?id='.$diff_id.
+            '&large=true'.
+            '#inline-'.$inline->getID();
         }
 
         $items[] = $item;