From 0ce85df7080b8468bc2f3931a1acb02d64dbb773 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Thu, 12 Sep 2013 16:00:09 -0700 Subject: [PATCH] Make Herald have "exists" and "not exists" options for differential reviewers on commit rules Summary: Fixes T1485. Test Plan: made a herald rule for "not exists". committed to master with no diff. audit was triggered Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Maniphest Tasks: T1485 Differential Revision: https://secure.phabricator.com/D6964 --- src/applications/herald/adapter/HeraldCommitAdapter.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/applications/herald/adapter/HeraldCommitAdapter.php b/src/applications/herald/adapter/HeraldCommitAdapter.php index fd41923d24..74cdf73a7e 100644 --- a/src/applications/herald/adapter/HeraldCommitAdapter.php +++ b/src/applications/herald/adapter/HeraldCommitAdapter.php @@ -71,6 +71,13 @@ final class HeraldCommitAdapter extends HeraldAdapter { public function getConditionsForField($field) { switch ($field) { case self::FIELD_DIFFERENTIAL_REVIEWERS: + return array( + self::CONDITION_EXISTS, + self::CONDITION_NOT_EXISTS, + self::CONDITION_INCLUDE_ALL, + self::CONDITION_INCLUDE_ANY, + self::CONDITION_INCLUDE_NONE, + ); case self::FIELD_DIFFERENTIAL_CCS: return array( self::CONDITION_INCLUDE_ALL,