From 0ddfd0b4fb05362aafb48d4e4165de799602487e Mon Sep 17 00:00:00 2001 From: Nick Harper Date: Wed, 23 May 2012 14:57:54 -0700 Subject: [PATCH] Show less misleading summary, test plan authors Summary: Instead of assuming the test plan and summary are written by the author of the differential revision, let's assume they are written by the author of the latest differential diff. Test Plan: viewed a drev that had been commandeered but not updated to check authors Reviewers: epriestley, jungejason, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1235 Differential Revision: https://secure.phabricator.com/D2550 --- .../revisionview/DifferentialRevisionViewController.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php index 92ba4b7c65..f30fe9a341 100644 --- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php @@ -364,8 +364,10 @@ final class DifferentialRevisionViewController extends DifferentialController { private function getImplicitComments(DifferentialRevision $revision) { + $diff = $revision->loadActiveDiff(); + $template = new DifferentialComment(); - $template->setAuthorPHID($revision->getAuthorPHID()); + $template->setAuthorPHID($diff->getAuthorPHID()); $template->setRevisionID($revision->getID()); $template->setDateCreated($revision->getDateCreated());