From 0e7049e8aafc39c92aedd6b84be54ad2b92d488d Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Thu, 15 Dec 2011 12:33:12 -0800 Subject: [PATCH] Countdown - kill tabs Summary: pretty simple stuff here. "View" controller had a 'view' tab selected which DNE. Test Plan: viewed countdown, noted no tabs Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T631 Differential Revision: 1222 --- .../controller/base/PhabricatorCountdownController.php | 8 -------- .../list/PhabricatorCountdownListController.php | 1 - .../view/PhabricatorCountdownViewController.php | 1 - 3 files changed, 10 deletions(-) diff --git a/src/applications/countdown/controller/base/PhabricatorCountdownController.php b/src/applications/countdown/controller/base/PhabricatorCountdownController.php index 89175a6d0a..23d7e88995 100644 --- a/src/applications/countdown/controller/base/PhabricatorCountdownController.php +++ b/src/applications/countdown/controller/base/PhabricatorCountdownController.php @@ -26,14 +26,6 @@ abstract class PhabricatorCountdownController extends PhabricatorController { $page->setBaseURI('/countdown/'); $page->setTitle(idx($data, 'title')); $page->setGlyph("\xE2\x9A\xB2"); - $page->setTabs( - array( - 'list' => array( - 'href' => '/countdown/', - 'name' => 'Countdown List', - ), - ), - idx($data, 'tab')); $page->setShowChrome(idx($data, 'chrome', true)); $page->appendChild($view); diff --git a/src/applications/countdown/controller/list/PhabricatorCountdownListController.php b/src/applications/countdown/controller/list/PhabricatorCountdownListController.php index b9e6aa0ae8..1e23fe181c 100644 --- a/src/applications/countdown/controller/list/PhabricatorCountdownListController.php +++ b/src/applications/countdown/controller/list/PhabricatorCountdownListController.php @@ -106,7 +106,6 @@ class PhabricatorCountdownListController return $this->buildStandardPageResponse($panel, array( 'title' => 'Countdown', - 'tab' => 'list', )); } } diff --git a/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php b/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php index 964ec885b7..c3119b39f6 100644 --- a/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php +++ b/src/applications/countdown/controller/view/PhabricatorCountdownViewController.php @@ -80,7 +80,6 @@ class PhabricatorCountdownViewController $panel, array( 'title' => 'Countdown: '.$timer->getTitle(), - 'tab' => 'view', 'chrome' => $chrome_visible )); }