Files - kill tabs
Summary: kill tabs for Files application. Technique is the "filter list" on the left hand side, with separation for "Files" versus "Image Macros". UI quirks include: - the page title does not change for the 3 files filters while it does change for each of the two image macro filters. - standalone "file" pages do not have the filter view - you can visit /file/upload/ standalone and it doesn't have the pretty filter list on it Please do give direction on these quirks if you like. :) This change also neuters the ?author= functionality for files. The code is written such that it can easily be brought back. Test Plan: clicked around on the filters, liked what I saw. uploaded files fancy-like and basic-like and it worked! made image macros and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T631 Differential Revision: 1219
This commit is contained in:
@@ -51,6 +51,7 @@ class AphrontDefaultApplicationConfiguration
|
||||
),
|
||||
'/file/' => array(
|
||||
'$' => 'PhabricatorFileListController',
|
||||
'filter/(?P<filter>\w+)/$' => 'PhabricatorFileListController',
|
||||
'upload/$' => 'PhabricatorFileUploadController',
|
||||
'dropupload/$' => 'PhabricatorFileDropUploadController',
|
||||
'(?P<view>info)/(?P<phid>[^/]+)/' => 'PhabricatorFileViewController',
|
||||
|
||||
Reference in New Issue
Block a user