From 13b4b37d30d2944968a232a71bbcbfd4a3adef4a Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 11 Oct 2016 12:32:32 -0700 Subject: [PATCH] Force a couple of Conduit results to the proper types in Calendar Summary: Ref T11706. Add some casts so we don't return `"0"` for `false`. Also I forgot to document one of the things. Test Plan: Called `calendar.event.search`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11706 Differential Revision: https://secure.phabricator.com/D16690 --- .../calendar/storage/PhabricatorCalendarEvent.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php index e6ad12ab3c..fd70d7780f 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php @@ -1056,6 +1056,10 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO ->setKey('description') ->setType('string') ->setDescription(pht('The event description.')), + id(new PhabricatorConduitSearchFieldSpecification()) + ->setKey('isAllDay') + ->setType('bool') + ->setDescription(pht('True if the event is an all day event.')), id(new PhabricatorConduitSearchFieldSpecification()) ->setKey('startDateTime') ->setType('datetime') @@ -1074,7 +1078,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO return array( 'name' => $this->getName(), 'description' => $this->getDescription(), - 'isAllDay' => $this->getIsAllDay(), + 'isAllDay' => (bool)$this->getIsAllDay(), 'startDateTime' => $this->getConduitDateTime($start_datetime), 'endDateTime' => $this->getConduitDateTime($end_datetime), ); @@ -1097,7 +1101,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO ->overrideTimezoneIdentifier($this->viewerTimezone); return array( - 'epoch' => $epoch, + 'epoch' => (int)$epoch, 'display' => array( 'default' => phabricator_datetime($epoch, $viewer), ),