From 13d930b232dc16ef4c41ea4b9d4f3a2e1d413e3d Mon Sep 17 00:00:00 2001
From: Nick Harper <nharper@fb.com>
Date: Fri, 6 Jan 2012 14:46:25 -0800
Subject: [PATCH] Fix table layout bug for inline comments

Summary:
The filename header for inline comments used to span 2 columns - the line number
and the comment. With the addition of a column for the diff (to link to inline
comments on previous diffs), the filename header should now span 3 columns
instead of just the line number and diff, leaving the comment squished to the
right.

Test Plan:
Opened a differential revision with an inline comment from a previous diff, and
saw that the filename header continued across the comment. Also checked an
inline comment on a current diff, and saw that it looks fine.

Reviewers: epriestley, btrahan, jungejason

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1340
---
 .../view/revisioncomment/DifferentialRevisionCommentView.php    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
index f5d57e1771..2d6fda43ee 100644
--- a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
+++ b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
@@ -176,7 +176,7 @@ final class DifferentialRevisionCommentView extends AphrontView {
         $inlines = msort($inlines, 'getLineNumber');
         $inline_render[] =
           '<tr>'.
-            '<th colspan="2">'.
+            '<th colspan="3">'.
               phutil_escape_html($changeset->getFileName()).
             '</th>'.
           '</tr>';