Improve "Ignore" action for setup warnings

Summary:
  - The dialog has no body text.
  - It uses an "Ignore" link because it predates action items.

Test Plan:
{F49894}
{F49895}
{F49896}

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6433
This commit is contained in:
epriestley
2013-07-12 11:20:24 -07:00
parent d1e25e3d11
commit 147302dfa6
2 changed files with 27 additions and 20 deletions

View File

@@ -58,23 +58,22 @@ final class PhabricatorConfigIssueListController
->setHref($href)
->addAttribute($issue->getSummary());
if (!$issue->getIsIgnored()) {
$item->addIcon('warning', pht('Setup Warning'));
$link = javelin_tag(
'a',
array('href' => '/config/ignore/'.$issue->getIssueKey().'/',
'sigil' => 'workflow'),
pht('Ignore'));
$item->setBarColor('yellow');
$item->addAttribute($link);
$item->addAction(
id(new PHUIListItemView())
->setIcon('unpublish')
->setWorkflow(true)
->setName(pht('Ignore'))
->setHref('/config/ignore/'.$issue->getIssueKey().'/'));
$list->addItem($item);
} else {
$item->addIcon('none', pht('Ignored'));
$link = javelin_tag(
'a',
array('href' => '/config/unignore/'.$issue->getIssueKey().'/',
'sigil' => 'workflow'),
pht('Unignore'));
$item->addAttribute($link);
$item->addAction(
id(new PHUIListItemView())
->setIcon('preview')
->setWorkflow(true)
->setName(pht('Unignore'))
->setHref('/config/unignore/'.$issue->getIssueKey().'/'));
$item->setBarColor('none');
$ignored_items[] = $item;
}