From 1539b21b45c6fbe9a51c1b62b9db9e16f8ae3970 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 28 Feb 2013 08:47:51 -0800
Subject: [PATCH] Fix overescaping for Repositories home screen

Summary: Fixes T2623.

Test Plan:
{F34157}

{F34158}

Reviewers: chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2623

Differential Revision: https://secure.phabricator.com/D5156
---
 .../controller/DiffusionHomeController.php    | 29 ++++++++++++-------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/src/applications/diffusion/controller/DiffusionHomeController.php b/src/applications/diffusion/controller/DiffusionHomeController.php
index 50685ffa3e..3f4231ee3a 100644
--- a/src/applications/diffusion/controller/DiffusionHomeController.php
+++ b/src/applications/diffusion/controller/DiffusionHomeController.php
@@ -147,18 +147,27 @@ final class DiffusionHomeController extends DiffusionController {
 
     $repository_tool_uri = PhabricatorEnv::getProductionURI('/repository/');
     $repository_tool     = phutil_tag('a',
-                                             array(
-                                               'href' => $repository_tool_uri,
-                                             ),
-                                             'repository tool');
-    $no_repositories_txt = 'This instance of Phabricator does not have any '.
-                           'configured repositories. ';
+      array(
+       'href' => $repository_tool_uri,
+      ),
+      'repository tool');
+    $preface = pht('This instance of Phabricator does not have any '.
+                   'configured repositories.');
     if ($user->getIsAdmin()) {
-      $no_repositories_txt .= 'To setup one or more repositories, visit the '.
-                              $repository_tool.'.';
+      $no_repositories_txt = hsprintf(
+        '%s %s',
+        $preface,
+        pht(
+          'To setup one or more repositories, visit the %s.',
+          $repository_tool));
     } else {
-      $no_repositories_txt .= 'Ask an administrator to setup one or more '.
-                              'repositories via the '.$repository_tool.'.';
+      $no_repositories_txt = hsprintf(
+        '%s %s',
+        $preface,
+        pht(
+          'Ask an administrator to setup one or more repositories '.
+          'via the %s.',
+          $repository_tool));
     }
 
     $table = new AphrontTableView($rows);