From 173adec5278836ca624b5d7b487a12e4cc182cd8 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 22 Sep 2013 19:49:37 -0700 Subject: [PATCH] Fix issue with checkbox custom controls that have no strings defined Summary: Fixes T3864. If you define a "bool" control but don't define a corresponding "strings", we currently fatal when trying to `idx()` into `null`. Auditors: btrahan --- .../customfield/standard/PhabricatorStandardCustomField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php index 4b045fb307..a09efcaac0 100644 --- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php +++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php @@ -9,7 +9,7 @@ abstract class PhabricatorStandardCustomField private $fieldDescription; private $fieldConfig; private $applicationField; - private $strings; + private $strings = array(); private $caption; private $fieldError; private $required;