From 175799fab99b741519ebf55e07ac59544daa7ac7 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 15 Jun 2015 08:32:08 +1000 Subject: [PATCH] Remove `break` from hunk migration Summary: This `break` statement causes `./bin/hunks migrate` to only migrate one-hunk-at-a-time, which is unnecessary and slightly misleading. Instead, allow the script to migrate //all// legacy hunks to modern storage. In particular, this means that we can recommend that installs run this command sometime before D13222 is landed. Test Plan: It's a pain to setup the data necessary to test this, but this is identical to the change that I made on our production install when I migrated our hunk storage. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13288 --- .../management/PhabricatorHunksManagementMigrateWorkflow.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php b/src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php index 552376d2e0..90c0be1717 100644 --- a/src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php +++ b/src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php @@ -48,8 +48,6 @@ final class PhabricatorHunksManagementMigrateWorkflow new PhutilNumber($diff_len), sprintf('%.1f%%', 100 * ($diff_len / $old_len)))); } - - break; } if ($saw_any_rows) {