From 17b9ac41f1184b4d0e5bcc97d0403a8bb64e286b Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 19 Mar 2013 10:57:54 -0700 Subject: [PATCH] Treat keyCode 10 as "return" in JX.Event Summary: Fixes T2753. Return is sent as either 10 or 13, depending on browser and OS. See, e.g. [[ http://code.google.com/p/chromium/issues/detail?id=79407 | this Chromium issue ]]. Test Plan: @cystorm confirmed this patch fixes the issue on his system. Reviewers: btrahan, codeblock Reviewed By: codeblock CC: cystorm, aran Maniphest Tasks: T2753 Differential Revision: https://secure.phabricator.com/D5381 --- externals/javelinjs/src/core/Event.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/externals/javelinjs/src/core/Event.js b/externals/javelinjs/src/core/Event.js index ebe082d3f3..4fbde8b119 100644 --- a/externals/javelinjs/src/core/Event.js +++ b/externals/javelinjs/src/core/Event.js @@ -229,6 +229,10 @@ JX.install('Event', { _keymap : { 8 : 'delete', 9 : 'tab', + // On Windows and Linux, Chrome sends '10' for return. On Mac OS X, it + // sends 13. Other browsers evidence varying degrees of diversity in their + // behavior. Treat '10' and '13' identically. + 10 : 'return', 13 : 'return', 27 : 'esc', 37 : 'left',