From 1b4f5e38cec3230a620db3e3ab8bbf65bf8efbc1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 2 Jan 2016 05:09:10 -0800 Subject: [PATCH] Fix an issue with rendering some commit hovercards Summary: This logic wasn't quite right. Test Plan: Hovered over a recognized commit, got a valid hovercard Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14925 --- .../engineextension/DiffusionHovercardEngineExtension.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php b/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php index a8193e569f..64caee879f 100644 --- a/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php +++ b/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php @@ -28,7 +28,7 @@ final class DiffusionHovercardEngineExtension $author_phid = $commit->getAuthorPHID(); if ($author_phid) { - $author = $viewer->loadHandle($author)->renderLink(); + $author = $viewer->renderHandle($author_phid); } else { $commit_data = $commit->loadCommitData(); $author = phutil_tag('em', array(), $commit_data->getAuthorName());