From 1c3e21dda118109eca33d6adb872a82bcc00a1b4 Mon Sep 17 00:00:00 2001
From: tuomaspelkonen <tuomas.pelkonen@fb.com>
Date: Mon, 18 Apr 2011 16:10:18 -0700
Subject: [PATCH] Fixed replies to go on the correct side of the diff in
 Differential.

Summary:
Replies to comments went always to the left side of the diff. There
was a confusion between 'is_new' and 'on_right'. Database wants the
information if the reply is on the left or on the right. The database
does not care if the comment is a reply or an original comment.

The code looks a bit confusing, because the database field is called
'isNewFile' and that is used to determine, which side the comment
applies to.

Test Plan:
Tested that every of combination of new comment/reply to the left/right side
worked when editing and after submitting the comment.

Reviewed By: jungejason
Reviewers: jungejason
CC: epriestley, jungejason
Differential Revision: 148
---
 .../DifferentialInlineCommentEditController.php                 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php b/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
index 23315323bc..bca832497c 100644
--- a/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
+++ b/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
@@ -122,7 +122,7 @@ class DifferentialInlineCommentEditController extends DifferentialController {
           ->setAuthorPHID($user->getPHID())
           ->setLineNumber($number)
           ->setLineLength($length)
-          ->setIsNewFile($is_new)
+          ->setIsNewFile($on_right)
           ->setContent($text)
           ->save();