From 1e3d1271ada02ee80693901286152422d6e9d731 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 30 Jan 2018 13:01:09 -0800
Subject: [PATCH] Make push log "flags", "reject code" human readable; add
 crumbs to pull/push logs

Summary:
Depends on D18972. Ref T13049.

Currently, the "flags" columns renders an inscrutible bitmask which you have to go hunt down in the code. Show a list of flags in human-readable text instead.

The "code" column renders a meaningless integer code. Show a text description instead.

The pull logs and push logs pages don't have a crumb to go back up out of the current query. Add one.

Test Plan: Viewed push logs, no more arcane numbers. Saw and clicked crumbs on each log page.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13049

Differential Revision: https://secure.phabricator.com/D18973
---
 .../DiffusionPullLogListController.php        |  5 ++++
 .../DiffusionPushLogListController.php        |  5 ++++
 .../view/DiffusionPushLogListView.php         | 30 +++++++++++++++----
 3 files changed, 35 insertions(+), 5 deletions(-)

diff --git a/src/applications/diffusion/controller/DiffusionPullLogListController.php b/src/applications/diffusion/controller/DiffusionPullLogListController.php
index 29712be2a4..f3b570c815 100644
--- a/src/applications/diffusion/controller/DiffusionPullLogListController.php
+++ b/src/applications/diffusion/controller/DiffusionPullLogListController.php
@@ -9,4 +9,9 @@ final class DiffusionPullLogListController
       ->buildResponse();
   }
 
+  protected function buildApplicationCrumbs() {
+    return parent::buildApplicationCrumbs()
+      ->addTextCrumb(pht('Pull Logs'), $this->getApplicationURI('pulllog/'));
+  }
+
 }
diff --git a/src/applications/diffusion/controller/DiffusionPushLogListController.php b/src/applications/diffusion/controller/DiffusionPushLogListController.php
index 658e21674d..a6c612eebe 100644
--- a/src/applications/diffusion/controller/DiffusionPushLogListController.php
+++ b/src/applications/diffusion/controller/DiffusionPushLogListController.php
@@ -9,4 +9,9 @@ final class DiffusionPushLogListController
       ->buildResponse();
   }
 
+  protected function buildApplicationCrumbs() {
+    return parent::buildApplicationCrumbs()
+      ->addTextCrumb(pht('Push Logs'), $this->getApplicationURI('pushlog/'));
+  }
+
 }
diff --git a/src/applications/diffusion/view/DiffusionPushLogListView.php b/src/applications/diffusion/view/DiffusionPushLogListView.php
index 77f28671c6..e101625752 100644
--- a/src/applications/diffusion/view/DiffusionPushLogListView.php
+++ b/src/applications/diffusion/view/DiffusionPushLogListView.php
@@ -28,6 +28,9 @@ final class DiffusionPushLogListView extends AphrontView {
     // Only administrators can view remote addresses.
     $remotes_visible = $viewer->getIsAdmin();
 
+    $flag_map = PhabricatorRepositoryPushLog::getFlagDisplayNames();
+    $reject_map = PhabricatorRepositoryPushLog::getRejectCodeDisplayNames();
+
     $rows = array();
     $any_host = false;
     foreach ($logs as $log) {
@@ -59,6 +62,23 @@ final class DiffusionPushLogListView extends AphrontView {
         $device = null;
       }
 
+      $flags = $log->getChangeFlags();
+      $flag_names = array();
+      foreach ($flag_map as $flag_key => $flag_name) {
+        if (($flags & $flag_key) === $flag_key) {
+          $flag_names[] = $flag_name;
+        }
+      }
+      $flag_names = phutil_implode_html(
+        phutil_tag('br'),
+        $flag_names);
+
+      $reject_code = $log->getPushEvent()->getRejectCode();
+      $reject_label = idx(
+        $reject_map,
+        $reject_code,
+        pht('Unknown ("%s")', $reject_code));
+
       $rows[] = array(
         phutil_tag(
           'a',
@@ -85,10 +105,8 @@ final class DiffusionPushLogListView extends AphrontView {
             'href' => $repository->getCommitURI($log->getRefNew()),
           ),
           $log->getRefNewShort()),
-
-        // TODO: Make these human-readable.
-        $log->getChangeFlags(),
-        $log->getPushEvent()->getRejectCode(),
+        $flag_names,
+        $reject_label,
         $viewer->formatShortDateTime($log->getEpoch()),
       );
     }
@@ -107,7 +125,7 @@ final class DiffusionPushLogListView extends AphrontView {
           pht('Old'),
           pht('New'),
           pht('Flags'),
-          pht('Code'),
+          pht('Result'),
           pht('Date'),
         ))
       ->setColumnClasses(
@@ -122,6 +140,8 @@ final class DiffusionPushLogListView extends AphrontView {
           'wide',
           'n',
           'n',
+          '',
+          '',
           'right',
         ))
       ->setColumnVisibility(