From 1e743c91386a663471d4b2786445d5d83cb15336 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Mon, 19 Nov 2012 17:05:10 -0800 Subject: [PATCH] fix lightbox for when we have no $user or $request Summary: defensive program wins all battles Test Plan: lightbox still worked Reviewers: vrana, epriestley Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3975 --- src/view/page/PhabricatorStandardPageView.php | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php index 56f237187a..f059595501 100644 --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -95,26 +95,29 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { require_celerity_resource('phabricator-core-buttons-css'); require_celerity_resource('phabricator-standard-page-view'); + Javelin::initBehavior('workflow', array()); + $current_token = null; $request = $this->getRequest(); if ($request) { $user = $request->getUser(); if ($user) { $current_token = $user->getCSRFToken(); + $download_form = phabricator_render_form_magic($user); + $default_img_uri = + PhabricatorEnv::getCDNURI( + '/rsrc/image/icon/fatcow/document_black.png' + ); + + Javelin::initBehavior( + 'lightbox-attachments', + array( + 'defaultImageUri' => $default_img_uri, + 'downloadForm' => $download_form, + )); } } - Javelin::initBehavior('workflow', array()); - $download_form = phabricator_render_form_magic($user); - $default_img_uri = - PhabricatorEnv::getCDNURI('/rsrc/image/icon/fatcow/document_black.png'); - - Javelin::initBehavior( - 'lightbox-attachments', - array( - 'defaultImageUri' => $default_img_uri, - 'downloadForm' => $download_form, - )); Javelin::initBehavior('toggle-class', array()); Javelin::initBehavior('konami', array()); Javelin::initBehavior(