From 21d145c9dddabbdd75b4e5946334467e53c02db9 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Fri, 27 Jan 2023 16:13:16 +0100 Subject: [PATCH] Use the latest transaction modification time fore the hash --- scripts/bake/bake.php | 4 ++-- .../query/PhabricatorApplicationTransactionQuery.php | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/bake/bake.php b/scripts/bake/bake.php index 3387152822..bb21494c42 100644 --- a/scripts/bake/bake.php +++ b/scripts/bake/bake.php @@ -240,7 +240,7 @@ function GetRevisionHash($revision) { $xaction = id(new DifferentialTransactionQuery()) ->setViewer($viewer) ->withObjectPHIDs(array($revision->getPHID())) - ->setOrder('newest') + ->setOrder('updated') ->setLimit(1) ->executeOne(); @@ -405,7 +405,7 @@ function GetTaskHash($task) { $xaction = id(new ManiphestTransactionQuery()) ->setViewer($viewer) ->withObjectPHIDs(array($task->getPHID())) - ->setOrder('newest') + ->setOrder('updated') ->setLimit(1) ->executeOne(); diff --git a/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php b/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php index 195de601f0..14a1b5558e 100644 --- a/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php +++ b/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php @@ -304,6 +304,7 @@ abstract class PhabricatorApplicationTransactionQuery protected function newPagingMapFromPartialObject($object) { return parent::newPagingMapFromPartialObject($object) + array( 'created' => $object->getDateCreated(), + 'updated' => $object->getDateModified(), 'phid' => $object->getPHID(), ); } @@ -314,6 +315,10 @@ abstract class PhabricatorApplicationTransactionQuery 'vector' => array('created', 'phid'), 'name' => pht('Global'), ), + 'updated' => array( + 'vector' => array('updated', 'id'), + 'name' => pht('Date Updated (Latest First)'), + ), ); } @@ -324,6 +329,11 @@ abstract class PhabricatorApplicationTransactionQuery 'column' => 'dateCreated', 'type' => 'int', ), + 'updated' => array( + 'table' => 'x', + 'column' => 'dateModified', + 'type' => 'int', + ), 'phid' => array( 'table' => 'x', 'column' => 'phid',