diff --git a/conf/__init_conf__.php b/conf/__init_conf__.php index da4f275297..6cd7ecdd7e 100644 --- a/conf/__init_conf__.php +++ b/conf/__init_conf__.php @@ -1,7 +1,7 @@ array( - 'uri' => '/res/2b0c9b6a/rsrc/css/application/differential/changeset-view.css', + 'uri' => '/res/38f1bef2/rsrc/css/application/differential/changeset-view.css', 'type' => 'css', 'requires' => array( @@ -181,15 +181,16 @@ celerity_register_resource_map(array( ), 'differential-inline-comment-editor' => array( - 'uri' => '/res/ff5f42a9/rsrc/js/application/differential/DifferentialInlineCommentEditor.js', + 'uri' => '/res/3fef6fab/rsrc/js/application/differential/DifferentialInlineCommentEditor.js', 'type' => 'js', 'requires' => array( 0 => 'javelin-dom', - 1 => 'javelin-workflow', - 2 => 'javelin-util', - 3 => 'javelin-stratcom', - 4 => 'javelin-install', + 1 => 'javelin-util', + 2 => 'javelin-stratcom', + 3 => 'javelin-install', + 4 => 'javelin-request', + 5 => 'javelin-workflow', ), 'disk' => '/rsrc/js/application/differential/DifferentialInlineCommentEditor.js', ), @@ -503,7 +504,7 @@ celerity_register_resource_map(array( ), 'javelin-behavior-differential-edit-inline-comments' => array( - 'uri' => '/res/31a8ef7b/rsrc/js/application/differential/behavior-edit-inline-comments.js', + 'uri' => '/res/52ce0fe5/rsrc/js/application/differential/behavior-edit-inline-comments.js', 'type' => 'js', 'requires' => array( @@ -1931,6 +1932,27 @@ celerity_register_resource_map(array( 'uri' => '/res/pkg/46547a92/core.pkg.js', 'type' => 'js', ), + '4876e7f9' => + array( + 'name' => 'differential.pkg.css', + 'symbols' => + array( + 0 => 'differential-core-view-css', + 1 => 'differential-changeset-view-css', + 2 => 'differential-revision-detail-css', + 3 => 'differential-revision-history-css', + 4 => 'differential-table-of-contents-css', + 5 => 'differential-revision-comment-css', + 6 => 'differential-revision-add-comment-css', + 7 => 'differential-revision-comment-list-css', + 8 => 'phabricator-object-selector-css', + 9 => 'aphront-headsup-action-list-view-css', + 10 => 'phabricator-content-source-view-css', + 11 => 'differential-local-commits-view-css', + ), + 'uri' => '/res/pkg/4876e7f9/differential.pkg.css', + 'type' => 'css', + ), '4fbae2af' => array( 'name' => 'javelin.pkg.js', @@ -1960,7 +1982,7 @@ celerity_register_resource_map(array( 'uri' => '/res/pkg/61f9d480/diffusion.pkg.css', 'type' => 'css', ), - 'c8aaade8' => + '79c97d03' => array( 'name' => 'differential.pkg.js', 'symbols' => @@ -1981,70 +2003,49 @@ celerity_register_resource_map(array( 13 => 'javelin-behavior-phabricator-object-selector', 14 => 'differential-inline-comment-editor', ), - 'uri' => '/res/pkg/c8aaade8/differential.pkg.js', + 'uri' => '/res/pkg/79c97d03/differential.pkg.js', 'type' => 'js', ), - 'e1ccef96' => - array( - 'name' => 'differential.pkg.css', - 'symbols' => - array( - 0 => 'differential-core-view-css', - 1 => 'differential-changeset-view-css', - 2 => 'differential-revision-detail-css', - 3 => 'differential-revision-history-css', - 4 => 'differential-table-of-contents-css', - 5 => 'differential-revision-comment-css', - 6 => 'differential-revision-add-comment-css', - 7 => 'differential-revision-comment-list-css', - 8 => 'phabricator-object-selector-css', - 9 => 'aphront-headsup-action-list-view-css', - 10 => 'phabricator-content-source-view-css', - 11 => 'differential-local-commits-view-css', - ), - 'uri' => '/res/pkg/e1ccef96/differential.pkg.css', - 'type' => 'css', - ), ), 'reverse' => array( 'aphront-crumbs-view-css' => '29e2c5f1', 'aphront-dialog-view-css' => '29e2c5f1', 'aphront-form-view-css' => '29e2c5f1', - 'aphront-headsup-action-list-view-css' => 'e1ccef96', + 'aphront-headsup-action-list-view-css' => '4876e7f9', 'aphront-list-filter-view-css' => '29e2c5f1', 'aphront-panel-view-css' => '29e2c5f1', 'aphront-side-nav-view-css' => '29e2c5f1', 'aphront-table-view-css' => '29e2c5f1', 'aphront-tokenizer-control-css' => '29e2c5f1', 'aphront-typeahead-control-css' => '29e2c5f1', - 'differential-changeset-view-css' => 'e1ccef96', - 'differential-core-view-css' => 'e1ccef96', - 'differential-inline-comment-editor' => 'c8aaade8', - 'differential-local-commits-view-css' => 'e1ccef96', - 'differential-revision-add-comment-css' => 'e1ccef96', - 'differential-revision-comment-css' => 'e1ccef96', - 'differential-revision-comment-list-css' => 'e1ccef96', - 'differential-revision-detail-css' => 'e1ccef96', - 'differential-revision-history-css' => 'e1ccef96', - 'differential-table-of-contents-css' => 'e1ccef96', + 'differential-changeset-view-css' => '4876e7f9', + 'differential-core-view-css' => '4876e7f9', + 'differential-inline-comment-editor' => '79c97d03', + 'differential-local-commits-view-css' => '4876e7f9', + 'differential-revision-add-comment-css' => '4876e7f9', + 'differential-revision-comment-css' => '4876e7f9', + 'differential-revision-comment-list-css' => '4876e7f9', + 'differential-revision-detail-css' => '4876e7f9', + 'differential-revision-history-css' => '4876e7f9', + 'differential-table-of-contents-css' => '4876e7f9', 'diffusion-commit-view-css' => '61f9d480', 'javelin-behavior' => '4fbae2af', 'javelin-behavior-aphront-basic-tokenizer' => '080edee4', - 'javelin-behavior-aphront-drag-and-drop' => 'c8aaade8', - 'javelin-behavior-aphront-drag-and-drop-textarea' => 'c8aaade8', + 'javelin-behavior-aphront-drag-and-drop' => '79c97d03', + 'javelin-behavior-aphront-drag-and-drop-textarea' => '79c97d03', 'javelin-behavior-aphront-form-disable-on-submit' => '46547a92', - 'javelin-behavior-differential-accept-with-errors' => 'c8aaade8', - 'javelin-behavior-differential-add-reviewers-and-ccs' => 'c8aaade8', - 'javelin-behavior-differential-comment-jump' => 'c8aaade8', - 'javelin-behavior-differential-diff-radios' => 'c8aaade8', - 'javelin-behavior-differential-edit-inline-comments' => 'c8aaade8', - 'javelin-behavior-differential-feedback-preview' => 'c8aaade8', - 'javelin-behavior-differential-keyboard-navigation' => 'c8aaade8', - 'javelin-behavior-differential-populate' => 'c8aaade8', - 'javelin-behavior-differential-show-more' => 'c8aaade8', + 'javelin-behavior-differential-accept-with-errors' => '79c97d03', + 'javelin-behavior-differential-add-reviewers-and-ccs' => '79c97d03', + 'javelin-behavior-differential-comment-jump' => '79c97d03', + 'javelin-behavior-differential-diff-radios' => '79c97d03', + 'javelin-behavior-differential-edit-inline-comments' => '79c97d03', + 'javelin-behavior-differential-feedback-preview' => '79c97d03', + 'javelin-behavior-differential-keyboard-navigation' => '79c97d03', + 'javelin-behavior-differential-populate' => '79c97d03', + 'javelin-behavior-differential-show-more' => '79c97d03', 'javelin-behavior-phabricator-keyboard-shortcuts' => '46547a92', - 'javelin-behavior-phabricator-object-selector' => 'c8aaade8', + 'javelin-behavior-phabricator-object-selector' => '79c97d03', 'javelin-behavior-phabricator-watch-anchor' => '46547a92', 'javelin-behavior-refresh-csrf' => '46547a92', 'javelin-behavior-workflow' => '46547a92', @@ -2065,16 +2066,16 @@ celerity_register_resource_map(array( 'javelin-util' => '4fbae2af', 'javelin-vector' => '4fbae2af', 'javelin-workflow' => '46547a92', - 'phabricator-content-source-view-css' => 'e1ccef96', + 'phabricator-content-source-view-css' => '4876e7f9', 'phabricator-core-buttons-css' => '29e2c5f1', 'phabricator-core-css' => '29e2c5f1', 'phabricator-directory-css' => '29e2c5f1', - 'phabricator-drag-and-drop-file-upload' => 'c8aaade8', + 'phabricator-drag-and-drop-file-upload' => '79c97d03', 'phabricator-keyboard-shortcut' => '46547a92', 'phabricator-keyboard-shortcut-manager' => '46547a92', - 'phabricator-object-selector-css' => 'e1ccef96', + 'phabricator-object-selector-css' => '4876e7f9', 'phabricator-remarkup-css' => '29e2c5f1', - 'phabricator-shaped-request' => 'c8aaade8', + 'phabricator-shaped-request' => '79c97d03', 'phabricator-standard-page-view' => '29e2c5f1', 'syntax-highlighting-css' => '29e2c5f1', ), diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 19f4cdc13a..da22898fe2 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -228,6 +228,7 @@ phutil_register_library_map(array( 'DifferentialHunk' => 'applications/differential/storage/hunk', 'DifferentialInlineComment' => 'applications/differential/storage/inlinecomment', 'DifferentialInlineCommentEditController' => 'applications/differential/controller/inlinecommentedit', + 'DifferentialInlineCommentEditView' => 'applications/differential/view/inlinecommentedit', 'DifferentialInlineCommentPreviewController' => 'applications/differential/controller/inlinecommentpreview', 'DifferentialInlineCommentView' => 'applications/differential/view/inlinecomment', 'DifferentialLinesFieldSpecification' => 'applications/differential/field/specification/lines', @@ -1081,6 +1082,7 @@ phutil_register_library_map(array( 'DifferentialHunk' => 'DifferentialDAO', 'DifferentialInlineComment' => 'DifferentialDAO', 'DifferentialInlineCommentEditController' => 'DifferentialController', + 'DifferentialInlineCommentEditView' => 'AphrontView', 'DifferentialInlineCommentPreviewController' => 'DifferentialController', 'DifferentialInlineCommentView' => 'AphrontView', 'DifferentialLinesFieldSpecification' => 'DifferentialFieldSpecification', diff --git a/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php b/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php index 63eb1424e0..d36cfc25f0 100644 --- a/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php +++ b/src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php @@ -40,14 +40,11 @@ class DifferentialInlineCommentEditController extends DifferentialController { $submit_uri = '/differential/comment/inline/edit/'.$this->revisionID.'/'; - $edit_dialog = new AphrontDialogView(); + $edit_dialog = new DifferentialInlineCommentEditView(); $edit_dialog->setUser($user); $edit_dialog->setSubmitURI($submit_uri); - $edit_dialog->addHiddenInput('on_right', $on_right); - - $edit_dialog->addSubmitButton(); - $edit_dialog->addCancelButton('#'); + $edit_dialog->setOnRight($on_right); switch ($op) { case 'delete': @@ -58,13 +55,19 @@ class DifferentialInlineCommentEditController extends DifferentialController { return $this->buildEmptyResponse(); } - $edit_dialog->setTitle('Really delete this comment?'); - $edit_dialog->addHiddenInput('id', $inline_id); - $edit_dialog->addHiddenInput('op', 'delete'); - $edit_dialog->appendChild( - '
Delete this inline comment?
'); + $dialog = new AphrontDialogView(); + $dialog->setUser($user); + $dialog->setSubmitURI($submit_uri); - return id(new AphrontDialogResponse())->setDialog($edit_dialog); + $dialog->setTitle('Really delete this comment?'); + $dialog->addHiddenInput('id', $inline_id); + $dialog->addHiddenInput('op', 'delete'); + $dialog->appendChild('Delete this inline comment?
'); + + $dialog->addCancelButton('#'); + $dialog->addSubmitButton(); + + return id(new AphrontDialogResponse())->setDialog($dialog); case 'edit': $inline = $this->loadInlineCommentForEditing($inline_id); @@ -91,7 +94,8 @@ class DifferentialInlineCommentEditController extends DifferentialController { $this->renderTextArea( nonempty($text, $inline->getContent()))); - return id(new AphrontDialogResponse())->setDialog($edit_dialog); + return id(new AphrontAjaxResponse()) + ->setContent($edit_dialog->render()); case 'create': if (!$request->isFormPost() || !strlen($text)) { @@ -120,7 +124,6 @@ class DifferentialInlineCommentEditController extends DifferentialController { case 'reply': default: - if ($op == 'reply') { $inline = $this->loadInlineComment($inline_id); // Override defaults. @@ -141,7 +144,8 @@ class DifferentialInlineCommentEditController extends DifferentialController { $edit_dialog->appendChild($this->renderTextArea($text)); - return id(new AphrontDialogResponse())->setDialog($edit_dialog); + return id(new AphrontAjaxResponse()) + ->setContent($edit_dialog->render()); } } diff --git a/src/applications/differential/controller/inlinecommentedit/__init__.php b/src/applications/differential/controller/inlinecommentedit/__init__.php index 553cef5304..f92cca08c9 100644 --- a/src/applications/differential/controller/inlinecommentedit/__init__.php +++ b/src/applications/differential/controller/inlinecommentedit/__init__.php @@ -13,6 +13,7 @@ phutil_require_module('phabricator', 'applications/differential/storage/changese phutil_require_module('phabricator', 'applications/differential/storage/inlinecomment'); phutil_require_module('phabricator', 'applications/differential/storage/revision'); phutil_require_module('phabricator', 'applications/differential/view/inlinecomment'); +phutil_require_module('phabricator', 'applications/differential/view/inlinecommentedit'); phutil_require_module('phabricator', 'applications/markup/engine'); phutil_require_module('phabricator', 'applications/phid/handle/data'); phutil_require_module('phabricator', 'infrastructure/javelin/markup'); diff --git a/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php b/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php index 724241c5ec..bd1c261fc4 100644 --- a/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php +++ b/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php @@ -212,13 +212,17 @@ class DifferentialChangesetListView extends AphrontView { Javelin::initBehavior('differential-edit-inline-comments', array( 'uri' => '/differential/comment/inline/edit/'.$revision->getID().'/', 'undo_templates' => $undo_templates, + 'stage' => 'differential-review-stage', )); } - return - '