From 27e2198e11fa810b88dd7c4bda6bb16548ec3c3d Mon Sep 17 00:00:00 2001 From: Asher Baker Date: Fri, 18 Jan 2013 06:19:32 -0800 Subject: [PATCH] Fix displaying non-image files. Summary: The Files application currently tries to render all browser-viewable files in an img tag, not taking into account if they're an image or not. Test Plan: Looked at various image and non-image files. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4511 --- .../files/controller/PhabricatorFileInfoController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/files/controller/PhabricatorFileInfoController.php b/src/applications/files/controller/PhabricatorFileInfoController.php index 293ee7b320..cff0b780b1 100644 --- a/src/applications/files/controller/PhabricatorFileInfoController.php +++ b/src/applications/files/controller/PhabricatorFileInfoController.php @@ -136,7 +136,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController { } } - if ($file->isViewableInBrowser()) { + if ($file->isViewableImage()) { // TODO: Clean this up after Pholio (dark backgrounds, standardization, // etc.)