archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix error when deleting revision

Browse Source 
Summary: DifferentialAffectedPath has no id or phid key so delete() won't work and we have to do things this other way.

Test Plan: deleted a few diffs on my test reproduction. aside from warnings about missing keys (epriestley is on it as I write this) no errors found and diff observed as deleted

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1846

Differential Revision: https://secure.phabricator.com/D3610
This commit is contained in:
Bob Trahan
2012-10-03 15:50:42 -07:00
parent 1f4c3ee167
commit 284bf71a8d
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/applications/differential/storage/DifferentialRevision.php
View File

@@ -226,12 +226,14 @@ final class DifferentialRevision extends DifferentialDAO {
$field->delete(); $field->delete();
} }
$paths = id(new DifferentialAffectedPath())->loadAllWhere( // we have to do paths a little differentally as they do not have
'revisionID = %d', // an id or phid column for delete() to act on
$dummy_path = new DifferentialAffectedPath();
queryfx(
$conn_w,
'DELETE FROM %T WHERE revisionID = %d',
$dummy_path->getTableName(),
$this->getID()); $this->getID());
foreach ($paths as $path) {
$path->delete();
}
$result = parent::delete(); $result = parent::delete();
$this->saveTransaction(); $this->saveTransaction();