From 2941b34acbbaaa0b12a1e9911fa6ec07821390af Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 11 Jan 2017 09:45:37 -0800
Subject: [PATCH] Add "diffusion.commit.edit", a v3 edit API endpoint for
 commits

Summary: Ref T10978. This currently does almost nothing, but gets it in place so I can add stuff to it.

Test Plan: Made a comment on a commit using the API.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10978

Differential Revision: https://secure.phabricator.com/D17178
---
 src/__phutil_library_map__.php                |  2 ++
 .../DiffusionCommitEditConduitAPIMethod.php   | 20 +++++++++++++++++++
 .../editor/DiffusionCommitEditEngine.php      | 11 +++++++++-
 3 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 5ebfc76a44..58383fd8d4 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -623,6 +623,7 @@ phutil_register_library_map(array(
     'DiffusionCommitDiffContentHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffContentHeraldField.php',
     'DiffusionCommitDiffContentRemovedHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffContentRemovedHeraldField.php',
     'DiffusionCommitDiffEnormousHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffEnormousHeraldField.php',
+    'DiffusionCommitEditConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php',
     'DiffusionCommitEditController' => 'applications/diffusion/controller/DiffusionCommitEditController.php',
     'DiffusionCommitEditEngine' => 'applications/diffusion/editor/DiffusionCommitEditEngine.php',
     'DiffusionCommitFulltextEngine' => 'applications/repository/search/DiffusionCommitFulltextEngine.php',
@@ -5316,6 +5317,7 @@ phutil_register_library_map(array(
     'DiffusionCommitDiffContentHeraldField' => 'DiffusionCommitHeraldField',
     'DiffusionCommitDiffContentRemovedHeraldField' => 'DiffusionCommitHeraldField',
     'DiffusionCommitDiffEnormousHeraldField' => 'DiffusionCommitHeraldField',
+    'DiffusionCommitEditConduitAPIMethod' => 'PhabricatorEditEngineAPIMethod',
     'DiffusionCommitEditController' => 'DiffusionController',
     'DiffusionCommitEditEngine' => 'PhabricatorEditEngine',
     'DiffusionCommitFulltextEngine' => 'PhabricatorFulltextEngine',
diff --git a/src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php
new file mode 100644
index 0000000000..442784a366
--- /dev/null
+++ b/src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php
@@ -0,0 +1,20 @@
+<?php
+
+final class DiffusionCommitEditConduitAPIMethod
+  extends PhabricatorEditEngineAPIMethod {
+
+  public function getAPIMethodName() {
+    return 'diffusion.commit.edit';
+  }
+
+  public function newEditEngine() {
+    return new DiffusionCommitEditEngine();
+  }
+
+  public function getMethodSummary() {
+    return pht(
+      'Apply transactions to edit an existing commit. This method can not '.
+      'create new commits.');
+  }
+
+}
diff --git a/src/applications/diffusion/editor/DiffusionCommitEditEngine.php b/src/applications/diffusion/editor/DiffusionCommitEditEngine.php
index 10acd24949..d07b3b2f17 100644
--- a/src/applications/diffusion/editor/DiffusionCommitEditEngine.php
+++ b/src/applications/diffusion/editor/DiffusionCommitEditEngine.php
@@ -26,7 +26,16 @@ final class DiffusionCommitEditEngine
   }
 
   protected function newEditableObject() {
-    throw new PhutilMethodNotImplementedException();
+    // NOTE: We must return a valid object here so that things like Conduit
+    // documentation generation work. You can't actually create commits via
+    // EditEngine. This is enforced with a "No One" creation policy.
+
+    $repository = new PhabricatorRepository();
+    $data = new PhabricatorRepositoryCommitData();
+
+    return id(new PhabricatorRepositoryCommit())
+      ->attachRepository($repository)
+      ->attachCommitData($data);
   }
 
   protected function newObjectQuery() {