From 2a815e0715da6463b3fe0ac9adcef28c91fbaaf5 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 16 Aug 2012 14:13:10 -0700
Subject: [PATCH] Fix a PhutilOpaqueEnvelope issue with `bin/storage dump`

Summary: We need to open the envelope here.

Test Plan: Ran `bin/storage dump` without errors.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3315
---
 .../PhabricatorStorageManagementDumpWorkflow.php     | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
index a58d4ba673..7d6aaa443b 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
@@ -45,9 +45,15 @@ final class PhabricatorStorageManagementDumpWorkflow
 
     list($host, $port) = $this->getBareHostAndPort($api->getHost());
 
-    $flag_password = $api->getPassword()
-      ? csprintf('-p %s', $api->getPassword())
-      : '';
+    $flag_password = '';
+
+    $password = $api->getPassword();
+    if ($password) {
+      $password = $password->openEnvelope();
+      if (strlen($password)) {
+        $flag_password = csprintf('-p %s', $password);
+      }
+    }
 
     $flag_port = $port
       ? csprintf('--port %d', $port)