diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php index 5a03483b2e..e73757d9c3 100644 --- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php @@ -169,11 +169,18 @@ class DifferentialRevisionViewController extends DifferentialController { $comment_view->setUser($user); $comment_view->setTargetDiff($target); + $changeset_view = new DifferentialChangesetListView(); + $changeset_view->setChangesets($visible_changesets); + $changeset_view->setEditable(true); + $changeset_view->setRevision($revision); + $changeset_view->setVsMap($vs_map); + $changeset_view->setWhitespace($request->getStr('whitespace')); + $diff_history = new DifferentialRevisionUpdateHistoryView(); $diff_history->setDiffs($diffs); $diff_history->setSelectedVersusDiffID($diff_vs); $diff_history->setSelectedDiffID($target->getID()); - $diff_history->setSelectedWhitespace($request->getStr('whitespace')); + $diff_history->setSelectedWhitespace($changeset_view->getWhitespace()); $toc_view = new DifferentialDiffTableOfContentsView(); $toc_view->setChangesets($changesets); @@ -181,12 +188,6 @@ class DifferentialRevisionViewController extends DifferentialController { $toc_view->setVsMap($vs_map); $toc_view->setRevisionID($revision->getID()); - $changeset_view = new DifferentialChangesetListView(); - $changeset_view->setChangesets($visible_changesets); - $changeset_view->setEditable(true); - $changeset_view->setRevision($revision); - $changeset_view->setVsMap($vs_map); - $changeset_view->setWhitespace($request->getStr('whitespace')); $draft = id(new PhabricatorDraft())->loadOneWhere( 'authorPHID = %s AND draftKey = %s', @@ -594,273 +595,3 @@ class DifferentialRevisionViewController extends DifferentialController { } } -/* - - - protected function getSandcastleURI(Diff $diff) { - $uri = $this->getDiffProperty($diff, 'facebook:sandcastle_uri'); - if (!$uri) { - $uri = $diff->getSandboxURL(); - } - return $uri; - } - - protected function getDiffProperty(Diff $diff, $property, $default = null) { - $diff_id = $diff->getID(); - if (empty($this->diffProperties[$diff_id])) { - $props = id(new DifferentialDiffProperty()) - ->loadAllWhere('diffID = %s', $diff_id); - $dict = array_pull($props, 'getData', 'getName'); - $this->diffProperties[$diff_id] = $dict; - } - return idx($this->diffProperties[$diff_id], $property, $default); - } - - $diff_table->appendChild( - - - - {id(