archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Split users apart from projects/packages in reviewer and audit UIs

Browse Source 
Summary: Ref T1279. Show separate sections for "Reviewers" and "Project Reviewers" (Differential) and for "Auditors" and "Package/Project Auditors" (Diffusion/Audit).

Test Plan:
  - Looked at a commit. Saw separation.
  - Looked at a revision. Saw separation.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7233
This commit is contained in:
epriestley
2013-10-05 07:54:42 -07:00
parent 9434df9d7c
commit 2d733f88a1
9 changed files with 191 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -473,7 +473,25 @@ final class DiffusionCommitController extends DiffusionController {
}
if ($audit_requests) {
$props['Auditors'] = $this->renderAuditStatusView($audit_requests);
$user_requests = array();
$other_requests = array();
foreach ($audit_requests as $audit_request) {
if ($audit_request->isUser()) {
$user_requests[] = $audit_request;
} else {
$other_requests[] = $audit_request;
}
}
if ($user_requests) {
$props['Auditors'] = $this->renderAuditStatusView(
$user_requests);
}
if ($other_requests) {
$props['Project/Package Auditors'] = $this->renderAuditStatusView(
$other_requests);
}
}
$props['Committed'] = phabricator_datetime($commit->getEpoch(), $user);
@@ -1012,6 +1030,11 @@ final class DiffusionCommitController extends DiffusionController {
case PhabricatorAuditStatusConstants::CC:
$item->setIcon('info-dark', pht('Subscribed'));
break;
default:
$item->setIcon(
'question-dark',
pht('%s?', $request->getAuditStatus()));
break;
}
$note = array();