From 2ebca7a245a3a52eef59f2917adba7db796debff Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 29 Apr 2015 14:03:36 -0700 Subject: [PATCH] Move Conpherence to "Zxxx" only, not "Exxx" Summary: Fixes T7439. Also two callsites I missed earlier. Test Plan: Tried to search for strings like `'E` and `"E`. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7439 Differential Revision: https://secure.phabricator.com/D12616 --- src/applications/conpherence/editor/ConpherenceEditor.php | 4 ++-- .../conpherence/mail/ConpherenceThreadMailReceiver.php | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/applications/conpherence/editor/ConpherenceEditor.php b/src/applications/conpherence/editor/ConpherenceEditor.php index 8c68cc98ca..698faec0e0 100644 --- a/src/applications/conpherence/editor/ConpherenceEditor.php +++ b/src/applications/conpherence/editor/ConpherenceEditor.php @@ -497,8 +497,8 @@ final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor { $phid = $object->getPHID(); return id(new PhabricatorMetaMTAMail()) - ->setSubject("E{$id}: {$title}") - ->addHeader('Thread-Topic', "E{$id}: {$phid}"); + ->setSubject("Z{$id}: {$title}") + ->addHeader('Thread-Topic', "Z{$id}: {$phid}"); } protected function getMailTo(PhabricatorLiskDAO $object) { diff --git a/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php b/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php index 95bea86fee..e926d3cfc5 100644 --- a/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php +++ b/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php @@ -9,13 +9,11 @@ final class ConpherenceThreadMailReceiver } protected function getObjectPattern() { - // TODO: Only recognize "Z" once we get closer to shipping Calendar. - return '[EZ][1-9]\d*'; + return 'Z[1-9]\d*'; } protected function loadObject($pattern, PhabricatorUser $viewer) { - // TODO: Only recognize "Z" once we get closer to shipping Calendar. - $id = (int)trim($pattern, 'EZ'); + $id = (int)trim($pattern, 'Z'); return id(new ConpherenceThreadQuery()) ->setViewer($viewer)