From 31927476e31c7cf9c0c2ea622c3cebb03ceb489d Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Sun, 21 Feb 2016 12:16:04 -0800 Subject: [PATCH] Reorder audit actions to match Differential Summary: These trip me up every time because Differential has: > Comment, Accept, Request Changes, Resign, Commandeer, Add Reviewers, Add Subscribers while audits currently show: > Comment, Add Subscribers, Add Auditors, Accept, Raise Concern, Resign Now they're more or less in the same order which helps with muscle memory. Test Plan: Careful inspection. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15323 --- .../diffusion/controller/DiffusionCommitController.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php index 9d6b845c91..6736b99430 100644 --- a/src/applications/diffusion/controller/DiffusionCommitController.php +++ b/src/applications/diffusion/controller/DiffusionCommitController.php @@ -790,8 +790,6 @@ final class DiffusionCommitController extends DiffusionController { $actions = array(); $actions[PhabricatorAuditActionConstants::COMMENT] = true; - $actions[PhabricatorAuditActionConstants::ADD_CCS] = true; - $actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true; // We allow you to accept your own commits. A use case here is that you // notice an issue with your own commit and "Raise Concern" as an indicator @@ -801,7 +799,6 @@ final class DiffusionCommitController extends DiffusionController { $actions[PhabricatorAuditActionConstants::ACCEPT] = true; $actions[PhabricatorAuditActionConstants::CONCERN] = true; - // To resign, a user must have authority on some request and not be the // commit's author. if (!$user_is_author) { @@ -837,6 +834,9 @@ final class DiffusionCommitController extends DiffusionController { $actions[PhabricatorAuditActionConstants::CLOSE] = true; } + $actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true; + $actions[PhabricatorAuditActionConstants::ADD_CCS] = true; + foreach ($actions as $constant => $ignored) { $actions[$constant] = PhabricatorAuditActionConstants::getActionName($constant);