From 31fcd78c766c4314c9d5a218489bcc333fe6611b Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 15 Jun 2012 17:00:26 -0700
Subject: [PATCH] Add "verified" or "unverified" to role output in user.query

Summary: See discussion in rP2f138d0501887fd0aca0f8536176f092880f662c.

Test Plan: Ran `user.query` on verified and unverified users.

Reviewers: csilvers, vrana

Reviewed By: csilvers

CC: aran

Differential Revision: https://secure.phabricator.com/D2768
---
 .../conduit/method/user/ConduitAPI_user_Method.php         | 7 +++++++
 .../conduit/method/user/ConduitAPI_user_query_Method.php   | 2 --
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/applications/conduit/method/user/ConduitAPI_user_Method.php b/src/applications/conduit/method/user/ConduitAPI_user_Method.php
index c2f4ec0e81..7a1080b14c 100644
--- a/src/applications/conduit/method/user/ConduitAPI_user_Method.php
+++ b/src/applications/conduit/method/user/ConduitAPI_user_Method.php
@@ -36,6 +36,13 @@ abstract class ConduitAPI_user_Method extends ConduitAPIMethod {
       $roles[] = 'admin';
     }
 
+    $primary = $user->loadPrimaryEmail();
+    if ($primary && $primary->getIsVerified()) {
+      $roles[] = 'verified';
+    } else {
+      $roles[] = 'unverified';
+    }
+
     $return = array(
       'phid'      => $user->getPHID(),
       'userName'  => $user->getUserName(),
diff --git a/src/applications/conduit/method/user/ConduitAPI_user_query_Method.php b/src/applications/conduit/method/user/ConduitAPI_user_query_Method.php
index 0018670bf9..f62ef4a8c6 100644
--- a/src/applications/conduit/method/user/ConduitAPI_user_query_Method.php
+++ b/src/applications/conduit/method/user/ConduitAPI_user_query_Method.php
@@ -64,8 +64,6 @@ final class ConduitAPI_user_query_Method
       $query->withUsernames($usernames);
     }
     if ($emails) {
-      // TODO -- validate emails and maybe
-      // throw new ConduitException('ERR-INVALID-PARAMETER');
       $query->withEmails($emails);
     }
     if ($realnames) {