From 32488687e74d4eaa5ade7dba3f64663bdec580a5 Mon Sep 17 00:00:00 2001 From: James Rhodes Date: Tue, 3 Feb 2015 22:59:29 +0000 Subject: [PATCH] Use %B for Harbormaster build log updates as well Summary: So I derped and missed the %s inside the `UPDATE` query (previously only fixing the `INSERT` query). This changes `%s` to `%B` for the update logic as well. Test Plan: Patched it in production and saw the offending build run all the way through without UTF8-related exceptions. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11669 --- .../harbormaster/storage/build/HarbormasterBuildLog.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php index 4540f64d0a..a40554cbea 100644 --- a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php +++ b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php @@ -133,7 +133,7 @@ final class HarbormasterBuildLog extends HarbormasterDAO queryfx( $conn, 'UPDATE harbormaster_buildlogchunk '. - 'SET chunk = CONCAT(chunk, %s), size = LENGTH(CONCAT(chunk, %s))'. + 'SET chunk = CONCAT(chunk, %B), size = LENGTH(CONCAT(chunk, %B))'. 'WHERE id = %d', $content, $content,