From 3512ba2b55e93a68d4ff591cabf5bca69b02b356 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 Jun 2012 07:51:56 -0700 Subject: [PATCH] Remove "TB" unit tests Summary: These fail on 32-bit machines and seem not valuable enough to try to make work with `bc`, etc. Test Plan: Ran tests (depends on D2622). Reviewers: floatinglomas, vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1298 Differential Revision: https://secure.phabricator.com/D2623 --- src/view/utils/__tests__/PhabricatorUnitsTestCase.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/view/utils/__tests__/PhabricatorUnitsTestCase.php b/src/view/utils/__tests__/PhabricatorUnitsTestCase.php index 7d4d3430b7..149bb123c4 100644 --- a/src/view/utils/__tests__/PhabricatorUnitsTestCase.php +++ b/src/view/utils/__tests__/PhabricatorUnitsTestCase.php @@ -18,6 +18,9 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase { + // NOTE: Keep tests below PHP_INT_MAX on 32-bit systems, since if you write + // larger numeric literals they'll evaluate to nonsense. + public function testByteFormatting() { $tests = array( 1 => '1 B', @@ -26,7 +29,6 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase { 10000000 => '10 MB', 100000000 => '100 MB', 1000000000 => '1 GB', - 1000000000000 => '1 TB', 999 => '999 B', ); @@ -48,7 +50,6 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase { '1KB' => 1000, '1MB' => 1000000, '1GB' => 1000000000, - '1TB' => 1000000000000, '1.5M' => 1500000, '1 000' => 1000, '1,234.56 KB' => 1234560,