diff --git a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php index 1453ab7d71..cdbbddd8d8 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php @@ -112,7 +112,7 @@ final class PhabricatorPeopleProfileViewController PhabricatorCustomField::ROLE_VIEW); $field_list->appendFieldsToPropertyList($user, $viewer, $view); - if ($view->isEmpty()) { + if (!$view->hasAnyProperties()) { return null; } diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php index c03b82b05d..74acd1edbf 100644 --- a/src/applications/project/controller/PhabricatorProjectProfileController.php +++ b/src/applications/project/controller/PhabricatorProjectProfileController.php @@ -125,7 +125,7 @@ final class PhabricatorProjectProfileController PhabricatorCustomField::ROLE_VIEW); $field_list->appendFieldsToPropertyList($project, $viewer, $view); - if ($view->isEmpty()) { + if (!$view->hasAnyProperties()) { return null; } diff --git a/src/applications/project/view/ProjectBoardTaskCard.php b/src/applications/project/view/ProjectBoardTaskCard.php index 9ae3ef83c8..86f4359c08 100644 --- a/src/applications/project/view/ProjectBoardTaskCard.php +++ b/src/applications/project/view/ProjectBoardTaskCard.php @@ -86,12 +86,11 @@ final class ProjectBoardTaskCard extends Phobject { $project_phids = array_fuse($task->getProjectPHIDs()); unset($project_phids[$this->project->getPHID()]); - $handle_list = $viewer->loadHandles($project_phids); - $tag_list = id(new PHUIHandleTagListView()) - ->setSlim(true) - ->setHandles($handle_list); - - if (!$tag_list->isEmpty()) { + if ($project_phids) { + $handle_list = $viewer->loadHandles($project_phids); + $tag_list = id(new PHUIHandleTagListView()) + ->setSlim(true) + ->setHandles($handle_list); $card->addAttribute($tag_list); } diff --git a/src/view/AphrontTagView.php b/src/view/AphrontTagView.php index b82ebef9c3..a6eb722383 100644 --- a/src/view/AphrontTagView.php +++ b/src/view/AphrontTagView.php @@ -77,10 +77,6 @@ abstract class AphrontTagView extends AphrontView { return $this->id; } - public function isEmpty() { - return empty($this->getTagContent()); - } - protected function getTagName() { return 'div'; } diff --git a/src/view/phui/PHUIPropertyListView.php b/src/view/phui/PHUIPropertyListView.php index 0d60ed25b0..336c494a3c 100644 --- a/src/view/phui/PHUIPropertyListView.php +++ b/src/view/phui/PHUIPropertyListView.php @@ -115,14 +115,14 @@ final class PHUIPropertyListView extends AphrontView { $this->invokedWillRenderEvent = true; } - public function isEmpty() { + public function hasAnyProperties() { $this->invokeWillRenderEvent(); if ($this->parts) { - return false; + return true; } - return true; + return false; } public function render() {