From 367cd289270d96e41ea88bf9576f4c9ca99552d1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 12 Aug 2020 09:29:52 -0700 Subject: [PATCH] Delete some commit dead parsing code Summary: Ref T13552. Neither "$hashes" or "$user" are used, and constructing them has no side effects. Test Plan: Searched for these symbols. Maniphest Tasks: T13552 Differential Revision: https://secure.phabricator.com/D21441 --- .../PhabricatorRepositoryCommitMessageParserWorker.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php index e589b52142..ab4719aee5 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php @@ -63,7 +63,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker $commit = $this->commit; $author = $ref->getAuthor(); $committer = $ref->getCommitter(); - $hashes = $ref->getHashes(); $has_committer = (bool)strlen($committer); $viewer = PhabricatorUser::getOmnipotentUser(); @@ -137,13 +136,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker $author_phid = $data->getCommitDetail('authorPHID'); $committer_phid = $data->getCommitDetail('committerPHID'); - $user = new PhabricatorUser(); - if ($author_phid) { - $user = $user->loadOneWhere( - 'phid = %s', - $author_phid); - } - if ($author_phid != $commit->getAuthorPHID()) { $commit->setAuthorPHID($author_phid); }