From 3a85d0bf5a74101105d025291f06a9a1b606bebc Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Fri, 12 Dec 2014 11:23:56 -0800
Subject: [PATCH] Transactions - change show all key from "~" to "@"

Summary: (some) international keyboard layouts can not type "~" in a way as to trigger this so use "@" instead. Save the suggested "+" as that seems like it would be useful for some future "adding stuff" keyboard workflow. Pretty stoked to get this squared away as I am quite confident our unreleased product will now be a huge smashing success. Ref T6683.

Test Plan: made sure my choice was okay via https://en.wikipedia.org/wiki/Dead_key#Dead_keys_on_various_keyboard_layouts; used the "@" key to show all transactions

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6683

Differential Revision: https://secure.phabricator.com/D10983
---
 resources/celerity/map.php                     | 18 +++++++++---------
 .../behavior-show-older-transactions.js        |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 12f8528295..317241b701 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
 return array(
   'names' => array(
     'core.pkg.css' => '669b2c21',
-    'core.pkg.js' => 'da3ab00a',
+    'core.pkg.js' => 'bc72b978',
     'darkconsole.pkg.js' => 'df001cab',
     'differential.pkg.css' => '8af45893',
     'differential.pkg.js' => '42c10e78',
@@ -420,7 +420,7 @@ return array(
     'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => 'd6f54db0',
-    'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '77fcaaee',
+    'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'bde958eb',
     'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
     'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
@@ -623,7 +623,7 @@ return array(
     'javelin-behavior-phabricator-remarkup-assist' => 'e32d14ab',
     'javelin-behavior-phabricator-reveal-content' => '60821bc7',
     'javelin-behavior-phabricator-search-typeahead' => '724b1247',
-    'javelin-behavior-phabricator-show-older-transactions' => '77fcaaee',
+    'javelin-behavior-phabricator-show-older-transactions' => 'bde958eb',
     'javelin-behavior-phabricator-tooltips' => '3ee3408b',
     'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb',
     'javelin-behavior-phabricator-transaction-list' => '13c739ea',
@@ -1308,12 +1308,6 @@ return array(
       'javelin-install',
       'javelin-util',
     ),
-    '77fcaaee' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'phabricator-busy',
-    ),
     '7814b593' => array(
       'javelin-request',
       'javelin-behavior',
@@ -1651,6 +1645,12 @@ return array(
       'phabricator-tooltip',
       'changeset-view-manager',
     ),
+    'bde958eb' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'phabricator-busy',
+    ),
     'be807912' => array(
       'javelin-behavior',
       'javelin-dom',
diff --git a/webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js b/webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js
index 10f33f5050..fbdde1a773 100644
--- a/webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js
+++ b/webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js
@@ -105,7 +105,7 @@ JX.behavior('phabricator-show-older-transactions', function(config) {
   JX.Stratcom.listen('hashchange', null, check_hash);
   check_hash();
 
-  new JX.KeyboardShortcut(['~'], 'Show all older changes in the timeline.')
+  new JX.KeyboardShortcut(['@'], 'Show all older changes in the timeline.')
     .setHandler(JX.bind(null, load_older, load_all_older_callback))
     .register();
 });