From 3a8cd60bab416c60d96d04962c9a72a209670c0b Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 16 Feb 2015 11:30:37 -0800
Subject: [PATCH] When cluster.instance is defined, use it to namespace S3
 objects

Summary: Ref T7163. This isn't //technically// necessary but seems generally desirable.

Test Plan: Will deploy S3 in production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7163

Differential Revision: https://secure.phabricator.com/D11770
---
 .../engine/PhabricatorS3FileStorageEngine.php | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/applications/files/engine/PhabricatorS3FileStorageEngine.php b/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
index d64a381c25..6dfbfc35f8 100644
--- a/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
@@ -32,12 +32,19 @@ final class PhabricatorS3FileStorageEngine
     // files more browsable with web/debugging tools like the S3 administration
     // tool.
     $seed = Filesystem::readRandomCharacters(20);
-    $parts = array(
-      substr($seed, 0, 2),
-      substr($seed, 2, 2),
-      substr($seed, 4),
-    );
-    $name = 'phabricator/'.implode('/', $parts);
+    $parts = array();
+    $parts[] = 'phabricator';
+
+    $instance_name = PhabricatorEnv::getEnvConfig('cluster.instance');
+    if (strlen($instance_name)) {
+      $parts[] = $instance_name;
+    }
+
+    $parts[] = substr($seed, 0, 2);
+    $parts[] = substr($seed, 2, 2);
+    $parts[] = substr($seed, 4);
+
+    $name = implode('/', $parts);
 
     AphrontWriteGuard::willWrite();
     $profiler = PhutilServiceProfiler::getInstance();