From 3ba2f506fec254d17386098a1fd9af605dd6e3d1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 26 Jul 2013 11:37:48 -0700 Subject: [PATCH] Remove leading whitespace if no prefix is configured for Asana sync Summary: Ref T2852. If the prefix is removed by configuration, we'll incorrectly leave a leading space. Trim any leading whitespace off. Test Plan: Ran `bin/feed republish` to sync an object to Asana Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2852 Differential Revision: https://secure.phabricator.com/D6575 --- .../DifferentialDoorkeeperRevisionFeedStoryPublisher.php | 2 +- .../doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php b/src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php index 25a3b397d3..e02f368113 100644 --- a/src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php +++ b/src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php @@ -51,7 +51,7 @@ final class DifferentialDoorkeeperRevisionFeedStoryPublisher $title = $object->getTitle(); - return "{$prefix} {$lines} D{$id}: {$title}"; + return ltrim("{$prefix} {$lines} D{$id}: {$title}"); } public function getObjectURI($object) { diff --git a/src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php b/src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php index cf17b95a5b..77fc99a302 100644 --- a/src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php +++ b/src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php @@ -112,7 +112,7 @@ final class DiffusionDoorkeeperCommitFeedStoryPublisher $title = $object->getSummary(); - return "{$prefix} {$name}: {$title}"; + return ltrim("{$prefix} {$name}: {$title}"); } public function getObjectURI($object) {