From 42e46bbe5a917f1de7f3ea068d67dfb0d607ffd1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 3 Feb 2020 05:04:01 -0800 Subject: [PATCH] Fix an issue where Herald rules could fail to evaluate at post-commit time Summary: Ref T13480. Some Herald fields need audit information, which recent changes to Herald adapters discarded. For now, just load it unconditionally. Test Plan: Triggered an Audit-related rule locally. Maniphest Tasks: T13480 Differential Revision: https://secure.phabricator.com/D20962 --- src/applications/diffusion/herald/HeraldCommitAdapter.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/diffusion/herald/HeraldCommitAdapter.php b/src/applications/diffusion/herald/HeraldCommitAdapter.php index d285d23f9b..59508d77fb 100644 --- a/src/applications/diffusion/herald/HeraldCommitAdapter.php +++ b/src/applications/diffusion/herald/HeraldCommitAdapter.php @@ -52,6 +52,7 @@ final class HeraldCommitAdapter ->withPHIDs(array($commit_phid)) ->needCommitData(true) ->needIdentities(true) + ->needAuditRequests(true) ->executeOne(); if (!$commit) { throw new Exception(