Respected canUninstall() :P
Summary: Disabled uninstalling of applications which can't be uninstalled. Also, applications which cannot be uninstalled always show that they are installed even if users somehow manually edit the configuration. Test Plan: Manually edited the URI to uninstall applications which can't be unisntalled. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4741
This commit is contained in:
committed by
epriestley
parent
cc95818384
commit
49beca445b
@@ -17,7 +17,7 @@ final class PhabricatorApplicationUninstallController
|
||||
|
||||
$selected = PhabricatorApplication::getByClass($this->application);
|
||||
|
||||
if (!$selected) {
|
||||
if (!$selected || !$selected->canUninstall()) {
|
||||
return new Aphront404Response();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user