From 4b15871ced9e66d16de04989c4ea656eff0536d0 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 12 Jun 2017 11:19:37 -0700 Subject: [PATCH] Fix specification of `ttl.relative` via LFS Summary: Fixes T12828. This API was tightened up D17616, but I missed this callsite. Test Plan: I've just got a good feeling in my bones. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12828 Differential Revision: https://secure.phabricator.com/D18119 --- .../files/uploadsource/PhabricatorFileUploadSource.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/applications/files/uploadsource/PhabricatorFileUploadSource.php b/src/applications/files/uploadsource/PhabricatorFileUploadSource.php index cda07d590b..5e72156091 100644 --- a/src/applications/files/uploadsource/PhabricatorFileUploadSource.php +++ b/src/applications/files/uploadsource/PhabricatorFileUploadSource.php @@ -208,11 +208,17 @@ abstract class PhabricatorFileUploadSource } private function getNewFileParameters() { - return array( + $parameters = array( 'name' => $this->getName(), - 'ttl.relative' => $this->getRelativeTTL(), 'viewPolicy' => $this->getViewPolicy(), ); + + $ttl = $this->getRelativeTTL(); + if ($ttl !== null) { + $parameters['ttl.relative'] = $ttl; + } + + return $parameters; } private function getChunkEngine() {