Conpherence - fix some ajax bugs

Summary: the people widget was returning a comma-delimited list of HTML nodes so kill that noise with some hsprintf action. We also weren't consistently updating the latest transaction id so simplify those codepaths (widgets vs pontificate) a bit. Fixes T3336.

Test Plan: left some messages, added some participants. noted that the people widget looked good and only the pertinent transactions were pulled down on updates.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3336

Differential Revision: https://secure.phabricator.com/D6180
This commit is contained in:
Bob Trahan
2013-06-11 15:07:53 -10:00
parent 6825e6ca77
commit 4c9c6fcda8
4 changed files with 18 additions and 20 deletions

View File

@@ -319,6 +319,10 @@ final class ConpherenceUpdateController
break;
}
$people_html = null;
if ($people_widget) {
$people_html = hsprintf('%s', $people_widget->render());
}
$content = array(
'transactions' => hsprintf('%s', $rendered_transactions),
'latest_transaction_id' => $new_latest_transaction_id,
@@ -326,7 +330,7 @@ final class ConpherenceUpdateController
'conpherence_phid' => $conpherence->getPHID(),
'header' => hsprintf('%s', $header),
'file_widget' => $file_widget ? $file_widget->render() : null,
'people_widget' => $people_widget ? $people_widget->render() : null,
'people_widget' => $people_html,
);
return $content;

View File

@@ -156,12 +156,9 @@ final class ConpherenceViewController extends
'type' => 'hidden',
'name' => 'latest_transaction_id',
'value' => $latest_transaction_id,
'sigil' => 'latest-transaction-id',
'meta' => array(
'id' => $latest_transaction_id
)
'sigil' => 'latest-transaction-id'
),
''))
''))
->render();
return $form;