Provide basic capabilities to make Differential column width flexible

Summary:
- Make wrap width settable in PHP.
  - Dynamically generate max-width based on configurable maximum width.
  - Constrain non-diff elements to standard width.
  - Provide a configuration setting.

Test Plan:
Set various things to 100 / 120, as far as I could tell everything seemed to
render sensibly? This should have no effect on 80-col changes.

Reviewed By: jdperlow
Reviewers: jdperlow, tuomaspelkonen, jungejason, aran
CC: aran, jdperlow
Differential Revision: 413
This commit is contained in:
epriestley
2011-06-08 12:39:03 -07:00
parent 4d3ef5ee0b
commit 4ec31ef75c
17 changed files with 212 additions and 33 deletions

View File

@@ -229,12 +229,13 @@ class DifferentialChangesetViewController extends DifferentialController {
$detail->setRevisionID($request->getInt('revision_id'));
$output =
'<div class="differential-primary-pane">'.
'<div class="differential-review-stage" '.
'id="differential-review-stage">'.
$detail->render().
'</div>'.
'</div>';
id(new DifferentialPrimaryPaneView())
->setLineWidthFromChangesets(array($changeset))
->appendChild(
'<div class="differential-review-stage" '.
'id="differential-review-stage">'.
$detail->render().
'</div>');
return $this->buildStandardPageResponse(
array(