From 53687827c6435dc6817ced81dc2497ddedb33d03 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 24 Jan 2014 12:29:13 -0800 Subject: [PATCH] Don't let Diffusion show that an importing repository is "100%" imported Summary: A few users have hit this and found it confusing. Currently, it means "more than 99.95%", which is very different from "100%". Instead: - show an extra digit of precision; and - cap the display at "99.99%", so it's more clear that work is still happening. Test Plan: Faked it and saw it cap at 99.99%. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D8058 --- .../controller/DiffusionRepositoryEditMainController.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php index 15ba1f2e73..a9ff6247ab 100644 --- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php +++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php @@ -954,7 +954,13 @@ final class DiffusionRepositoryEditMainController $percentage = 0; } - $percentage = sprintf('%.1f%%', $percentage); + // Cap this at "99.99%", because it's confusing to users when the actual + // fraction is "99.996%" and it rounds up to "100.00%". + if ($percentage > 99.99) { + $percentage = 99.99; + } + + $percentage = sprintf('%.2f%%', $percentage); $view->addItem( id(new PHUIStatusItemView())