From 53ffaaa889ec0cdc6f2a570b80aefd9deb76cb28 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 11 Aug 2015 06:39:05 -0700 Subject: [PATCH] Load buildables in DiffViewController Summary: Fixes T9128. I missed this when converting other controllers to look in Harbormaster for lint/unit data. Test Plan: Copy/pasted a diff successfully. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9128 Differential Revision: https://secure.phabricator.com/D13865 --- .../controller/DifferentialDiffViewController.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/applications/differential/controller/DifferentialDiffViewController.php b/src/applications/differential/controller/DifferentialDiffViewController.php index 9756634a81..28e7c2fc54 100644 --- a/src/applications/differential/controller/DifferentialDiffViewController.php +++ b/src/applications/differential/controller/DifferentialDiffViewController.php @@ -29,6 +29,17 @@ final class DifferentialDiffViewController extends DifferentialController { ->setURI('/D'.$diff->getRevisionID().'?id='.$diff->getID()); } + $diff_phid = $diff->getPHID(); + $buildables = id(new HarbormasterBuildableQuery()) + ->setViewer($viewer) + ->withBuildablePHIDs(array($diff_phid)) + ->withManualBuildables(false) + ->needBuilds(true) + ->needTargets(true) + ->execute(); + $buildables = mpull($buildables, null, 'getBuildablePHID'); + $diff->attachBuildable(idx($buildables, $diff_phid)); + // TODO: implement optgroup support in AphrontFormSelectControl? $select = array(); $select[] = hsprintf('', pht('Create New Revision'));