From 582e13fc38b37c8f1151437cd292e40d3baee4ac Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 1 Feb 2015 20:10:39 -0800 Subject: [PATCH] Change PHUIPagedFormView to extend AphrontView Summary: Debugging crumbs in repository editing, and it seems there are stray divs that aren't used from extending AphrontTagView. I don't see any specific reason this needs to be from AphrontTagView, so changing it. Of course I'm not sure this is correct, so feel free to reject if I'm missing some obvious or non-obvious reasons. Test Plan: Review editing a repositor, don't see extra div. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11608 --- src/view/form/PHUIPagedFormView.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/form/PHUIPagedFormView.php b/src/view/form/PHUIPagedFormView.php index ee40c3d496..82e58c7f58 100644 --- a/src/view/form/PHUIPagedFormView.php +++ b/src/view/form/PHUIPagedFormView.php @@ -3,7 +3,7 @@ /** * @task page Managing Pages */ -final class PHUIPagedFormView extends AphrontTagView { +final class PHUIPagedFormView extends AphrontView { private $name = 'pages'; private $pages = array(); @@ -220,7 +220,7 @@ final class PHUIPagedFormView extends AphrontTagView { return $this->cancelURI; } - protected function getTagContent() { + public function render() { $form = id(new AphrontFormView()) ->setUser($this->getUser());