Use assert_instances_of() in Differential
Summary: NOTE: This is not produced by a script so there might be errors. Please review carefully. Test Plan: Browse around Differential. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2103
This commit is contained in:
@@ -169,6 +169,7 @@ final class DifferentialChangesetParser {
|
||||
}
|
||||
|
||||
public function setHandles(array $handles) {
|
||||
assert_instances_of($handles, 'PhabricatorObjectHandle');
|
||||
$this->handles = $handles;
|
||||
return $this;
|
||||
}
|
||||
@@ -1173,6 +1174,9 @@ final class DifferentialChangesetParser {
|
||||
$feedback_mask,
|
||||
array $old_comments,
|
||||
array $new_comments) {
|
||||
foreach (array_merge($old_comments, $new_comments) as $comments) {
|
||||
assert_instances_of($comments, 'PhabricatorInlineCommentInterface');
|
||||
}
|
||||
|
||||
$context_not_available = null;
|
||||
if ($this->missingOld || $this->missingNew) {
|
||||
|
||||
Reference in New Issue
Block a user