archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"

Browse Source 
Summary: Ref T13250. See D20149. Mostly: clarify semantics. Partly: remove magic "null" behavior.

Test Plan: Poked around, but mostly just inspection since these are pretty much one-for-one.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20154
This commit is contained in:
epriestley
2019-02-12 13:35:59 -08:00
parent 241f06c9ff
commit 5892c78986
40 changed files with 87 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/auth/controller/PhabricatorAuthStartController.php
View File

@@ -54,7 +54,7 @@ final class PhabricatorAuthStartController
}
$redirect_uri = $request->getRequestURI();
$redirect_uri->setQueryParam('cleared', 1);
$redirect_uri->replaceQueryParam('cleared', 1);
return id(new AphrontRedirectResponse())->setURI($redirect_uri);
}
}
@@ -64,7 +64,7 @@ final class PhabricatorAuthStartController
// the workflow will continue normally.
if ($did_clear) {
$redirect_uri = $request->getRequestURI();
$redirect_uri->setQueryParam('cleared', null);
$redirect_uri->removeQueryParam('cleared');
return id(new AphrontRedirectResponse())->setURI($redirect_uri);
}